Use errorlevel of Sphinx main() in Doc\make.bat

[andresdelfino]

BPO	33670
Nosy	@pfmoore, @tjguk, @zware, @zooba, @andresdelfino, @miss-islington
PRs	bpo-33670: Expose Sphinx main() return in Doc\make.bat as errorlevel #7156 [3.7] bpo-33670: Expose Sphinx errorlevel (GH-7156) #7185 [3.6] bpo-33670: Expose Sphinx errorlevel (GH-7156) #7186 [2.7] bpo-33670: Expose Sphinx errorlevel (GH-7156). #7201

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/zooba'
closed_at = <Date 2018-05-29.22:31:06.854>
created_at = <Date 2018-05-28.15:37:25.175>
labels = ['type-feature', 'OS-windows']
title = 'Use errorlevel of Sphinx main() in Doc\\make.bat'
updated_at = <Date 2018-05-29.22:31:06.854>
user = 'https://github.com/andresdelfino'

bugs.python.org fields:

activity = <Date 2018-05-29.22:31:06.854>
actor = 'steve.dower'
assignee = 'steve.dower'
closed = True
closed_date = <Date 2018-05-29.22:31:06.854>
closer = 'steve.dower'
components = ['Demos and Tools', 'Windows']
creation = <Date 2018-05-28.15:37:25.175>
creator = 'adelfino'
dependencies = []
files = []
hgrepos = []
issue_num = 33670
keywords = ['patch']
message_count = 9.0
messages = ['317870', '317874', '317959', '317975', '317977', '317978', '317979', '318128', '318129']
nosy_count = 6.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'adelfino', 'miss-islington']
pr_nums = ['7156', '7185', '7186', '7201']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue33670'
versions = ['Python 2.7']

[andresdelfino]

Doc\make.bat is exiting without exposing Sphinx's main() return value, showing weird things like:

C:\Users\adelfino\Desktop\Personal\repos\cpython\Doc>make venv
Using py -3.6 (found with py.exe)
Merging Misc/NEWS with py -3.6 -m blurb
Running Sphinx v1.7.4

Sphinx error:
Builder name venv not registered or available through entry point

Build succeeded. All output should be in build\venv

PR fixes this.

[andresdelfino]

After the PR:

C:\Users\adelfino\Desktop\Personal\repos\cpython\Doc>make venv
Using py -3.6 (found with py.exe)
Merging Misc/NEWS with py -3.6 -m blurb
Running Sphinx v1.7.4

Sphinx error:
Builder name venv not registered or available through entry point

Build failed (exit code 2), check for error messages
above. Any output will be found in build\venv

[zooba]

New changeset 8c1ad0c by Steve Dower (Andrés Delfino) in branch 'master':
bpo-33670: Expose Sphinx errorlevel (GH-7156)
8c1ad0c

[miss-islington]

New changeset 1827615 by Miss Islington (bot) in branch '3.7':
bpo-33670: Expose Sphinx errorlevel (GH-7156)
1827615

[miss-islington]

New changeset 08beaf7 by Miss Islington (bot) in branch '3.6':
bpo-33670: Expose Sphinx errorlevel (GH-7156)
08beaf7

[zooba]

Thanks for the contribution! Looks like the automatic backport to 2.7 won't work, so someone will have to do one manually. I'm happy to hit merge on a PR (whoever does it, make sure you follow the backport naming rules in the PR template).

[andresdelfino]

Np! I'll take care of the backport :)