Failed separate test_patch_propogrates_exc_on_exit in test_unittest

[serhiy-storchaka]

BPO	33747
Nosy	@brettcannon, @voidspace, @serhiy-storchaka, @miss-islington
PRs	bpo-33747: Avoid mutating the global sys.modules dict #8520 [3.7] bpo-33747: Avoid mutating the global sys.modules dict in unittest.mock tests (GH-8520) #11031 [3.6] bpo-33747: Avoid mutating the global sys.modules dict in unittest.mock tests (GH-8520) #11032

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-12-11.10:19:06.759>
created_at = <Date 2018-06-03.11:59:10.600>
labels = ['3.7', '3.8', 'type-bug', 'tests']
title = 'Failed separate test_patch_propogrates_exc_on_exit in test_unittest'
updated_at = <Date 2018-12-11.10:19:06.758>
user = 'https://github.com/serhiy-storchaka'

bugs.python.org fields:

activity = <Date 2018-12-11.10:19:06.758>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2018-12-11.10:19:06.759>
closer = 'serhiy.storchaka'
components = ['Tests']
creation = <Date 2018-06-03.11:59:10.600>
creator = 'serhiy.storchaka'
dependencies = []
files = []
hgrepos = []
issue_num = 33747
keywords = ['patch']
message_count = 5.0
messages = ['318534', '322637', '331365', '331599', '331600']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'michael.foord', 'serhiy.storchaka', 'miss-islington']
pr_nums = ['8520', '11031', '11032']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue33747'
versions = ['Python 3.6', 'Python 3.7', 'Python 3.8']

[serhiy-storchaka]

$ ./python -m test -v -m test_patch_propogrates_exc_on_exit test_unittest
...
test_patch_propogrates_exc_on_exit (unittest.test.testmock.testpatch.PatchTest) ... ERROR

======================================================================
ERROR: test_patch_propogrates_exc_on_exit (unittest.test.testmock.testpatch.PatchTest)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/home/serhiy/py/cpython/Lib/unittest/test/testmock/testpatch.py", line 1699, in test_patch_propogrates_exc_on_exit
    self.assertRaises(RuntimeError, test)
  File "/home/serhiy/py/cpython/Lib/unittest/case.py", line 743, in assertRaises
    return context.handle('assertRaises', args, kwargs)
  File "/home/serhiy/py/cpython/Lib/unittest/case.py", line 178, in handle
    callable_obj(*args, **kwargs)
  File "/home/serhiy/py/cpython/Lib/unittest/mock.py", line 1183, in patched
    arg = patching.__enter__()
  File "/home/serhiy/py/cpython/Lib/unittest/mock.py", line 1239, in __enter__
    self.target = self.getter()
  File "/home/serhiy/py/cpython/Lib/unittest/mock.py", line 1409, in <lambda>
    getter = lambda: _importer(target)
  File "/home/serhiy/py/cpython/Lib/unittest/mock.py", line 1092, in _importer
    thing = __import__(import_path)
ModuleNotFoundError: No module named 'squizz'

---

[serhiy-storchaka]

Michael, could you please make a review? I'm not experienced with mock.patch, and don't know what this test do.

[brettcannon]

New changeset 3cf7438 by Brett Cannon (Anirudha Bose) in branch 'master':
bpo-33747: Avoid mutating the global sys.modules dict in unittest.mock tests (GH-8520)
3cf7438

[miss-islington]

New changeset 45a31a1 by Miss Islington (bot) in branch '3.7':
[3.7] bpo-33747: Avoid mutating the global sys.modules dict in unittest.mock tests (GH-8520) (GH-11031)
45a31a1

[miss-islington]

New changeset 7d9f219 by Miss Islington (bot) in branch '3.6':
[3.6] bpo-33747: Avoid mutating the global sys.modules dict in unittest.mock tests (GH-8520) (GH-11032)
7d9f219