Convert test_bz2 to use tempfile

[tjguk]

BPO	34239
Nosy	@brettcannon, @tjguk, @serhiy-storchaka
PRs	bpo-34239: Convert test_bz2 to use tempfile #8485

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tjguk'
closed_at = <Date 2018-07-28.17:28:37.361>
created_at = <Date 2018-07-26.17:28:08.907>
labels = ['type-bug', '3.8']
title = 'Convert test_bz2 to use tempfile'
updated_at = <Date 2018-07-28.17:28:37.360>
user = 'https://github.com/tjguk'

bugs.python.org fields:

activity = <Date 2018-07-28.17:28:37.360>
actor = 'tim.golden'
assignee = 'tim.golden'
closed = True
closed_date = <Date 2018-07-28.17:28:37.361>
closer = 'tim.golden'
components = []
creation = <Date 2018-07-26.17:28:08.907>
creator = 'tim.golden'
dependencies = []
files = []
hgrepos = []
issue_num = 34239
keywords = ['patch']
message_count = 5.0
messages = ['322441', '322451', '322461', '322517', '322528']
nosy_count = 4.0
nosy_names = ['brett.cannon', 'tim.golden', 'serhiy.storchaka', 'tjguk']
pr_nums = ['8485']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue34239'
versions = ['Python 3.8']

[tjguk]

test_bz2 currently uses the test.support.TESTFN functionality which creates a temporary file local to the test directory named around the pid.

This can give rise to race conditions where tests are competing with each other to delete and recreate the file.

[tjguk]

New changeset 6a62e1d by Tim Golden in branch 'master':
bpo-34239: Convert test_bz2 to use tempfile (bpo-8485)
6a62e1d

[serhiy-storchaka]

It is more reliable to use test.support.unlink().

[brettcannon]

Should this issue be closed, Tim, after you update for Serhiy's suggestion? (Basically I'm just making sure you know issues are not automatically closed after merge :) .

[tjguk]

Thanks, Brett. I'll address Serhiy's comment with a new PR and then tidy
yup.