COUNT_ALLOCS build export inc_count() and dec_count() functions which don't have a "Py_" prefix

[vstinner]

BPO	35064
Nosy	@vstinner, @pablogsal
PRs	bpo-35064 prefix smelly symbols that appear with COUNT_ALLOCS with _Py_ #10152

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2018-10-28.15:02:41.493>
created_at = <Date 2018-10-25.10:13:55.914>
labels = ['interpreter-core', '3.8']
title = 'COUNT_ALLOCS build export inc_count() and dec_count() functions which don\'t have a "Py_" prefix'
updated_at = <Date 2018-10-28.15:02:41.492>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2018-10-28.15:02:41.492>
actor = 'pablogsal'
assignee = 'none'
closed = True
closed_date = <Date 2018-10-28.15:02:41.493>
closer = 'pablogsal'
components = ['Interpreter Core']
creation = <Date 2018-10-25.10:13:55.914>
creator = 'vstinner'
dependencies = []
files = []
hgrepos = []
issue_num = 35064
keywords = ['patch']
message_count = 2.0
messages = ['328422', '328689']
nosy_count = 2.0
nosy_names = ['vstinner', 'pablogsal']
pr_nums = ['10152']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue35064'
versions = ['Python 3.8']

[vstinner]

Extract of Include/object.c:

#ifdef COUNT_ALLOCS
PyAPI_FUNC(void) inc_count(PyTypeObject *);
PyAPI_FUNC(void) dec_count(PyTypeObject *);

The "make smelly" fails with 10 symbols:

---

$ ./configure --with-pydebug CFLAGS="-D COUNT_ALLOCS -O0"
$ make smelly
(...)
./python Tools/scripts/smelly.py
+ nm -p libpython3.8dm.a
Ignored symbol types: b, d, r, t

Smelly symbol: dec_count (type: T)
Smelly symbol: dump_counts (type: T)
Smelly symbol: fast_tuple_allocs (type: C)
Smelly symbol: get_counts (type: T)
Smelly symbol: inc_count (type: T)
Smelly symbol: null_strings (type: C)
Smelly symbol: one_strings (type: C)
Smelly symbol: quick_int_allocs (type: C)
Smelly symbol: quick_neg_int_allocs (type: C)
Smelly symbol: tuple_zero_allocs (type: C)

ERROR: Found 10 smelly symbols!
---

These functions should be made private (declared with "static") or get a "Py_" prefix.

[pablogsal]

New changeset 49c75a8 by Pablo Galindo in branch 'master':
bpo-35064 prefix smelly symbols that appear with COUNT_ALLOCS with _Py_ (GH-10152)
49c75a8