Upgrade Windows tcl/tk to 8.6.11

[terryjreedy]

BPO	43652
Nosy	@terryjreedy, @pfmoore, @tjguk, @zware, @serhiy-storchaka, @zooba, @E-Paine
PRs	bpo-43652: Update Tcl and Tk to 8.6.11 in Windows installer #25170 bpo-43652: Actually update to Tcl/Tk 8.6.11 on Windows #29397 [3.10] bpo-43652: Actually update to Tcl/Tk 8.6.11 on Windows (GH-29397) #29407

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-04-23.21:41:34.695>
created_at = <Date 2021-03-29.07:07:11.686>
labels = ['type-feature', 'expert-tkinter', '3.10', 'OS-windows']
title = 'Upgrade Windows tcl/tk to 8.6.11'
updated_at = <Date 2021-11-04.19:35:01.498>
user = 'https://github.com/terryjreedy'

bugs.python.org fields:

activity = <Date 2021-11-04.19:35:01.498>
actor = 'terry.reedy'
assignee = 'none'
closed = True
closed_date = <Date 2021-04-23.21:41:34.695>
closer = 'steve.dower'
components = ['Tkinter', 'Windows']
creation = <Date 2021-03-29.07:07:11.686>
creator = 'terry.reedy'
dependencies = []
files = []
hgrepos = []
issue_num = 43652
keywords = ['patch']
message_count = 12.0
messages = ['389662', '389774', '389776', '390147', '390148', '391741', '391749', '405455', '405470', '405735', '405740', '405747']
nosy_count = 7.0
nosy_names = ['terry.reedy', 'paul.moore', 'tim.golden', 'zach.ware', 'serhiy.storchaka', 'steve.dower', 'epaine']
pr_nums = ['25170', '29397', '29407']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue43652'
versions = ['Python 3.10']

[terryjreedy]

bpo-39017, PR 22405 was too late for 3.9, but the new Mac installer is already using 8.6.11. Serhiy, do you know any reason not to upgrade the Windows installer to 8.6.11 also?

Steve, should a new PR with '10' replaced with '11, where '9' was replaced with '10' before, be sufficient? I presumt the 'v14' for VC13 should be left alone. To test, would 8.6.11 be built on my system, or is it fetched externally?

[zooba]

I also need to pull the Tcl and Tk sources into our cpython-source-deps repository, run a signed build, and put the binaries into the cpython-bin-deps repository. I'll get that started tonight, but probably won't finish it until tomorrow.

[zooba]

Turns out I did get it done, so you should be able to update the references you find in the PCbuild directory and get a build.

[terryjreedy]

Did you use revision 0, and in 8.6.11.0, or a later one?

As I mentioned in bpo-43719, I cannot currently build master, but I will upload a PR (with .0) for CI to test.

[terryjreedy]

The upgrade to 8.6.10 broke a Scale test. The fix for that in bpo-41306
conv = False if get_tk_patchlevel() >= (8, 6, 10) else float_round
should still work unless there was a further Scale change.

[zooba]

Thanks for finishing up that patch.

And yes, we add a ".0" in case we need to patch the sources ourselves.

[terryjreedy]

Previous issue, which I mistyped, was bpo-39107. Release notes at
https://sourceforge.net/projects/tcl/files/Tcl/8.6.11/tcltk-release-notes-8.6.11.txt/view

[E-Paine]

This does not seem to have done the trick. The installers for 3.10.0 and 3.11.0a1 both use Tk 8.6.10 still. This can be verified using the bug in bpo-45681 or using tkinter.test.support.get_tk_patchlevel().

[zooba]

Looks like something went wrong back when I built it in March and it built the older version again.

I probably need to revamp that build step. I think it relies on a race to build properly, since it's in the main repo. We need a way to override the version it's going to build without modifying the repo, since we can't modify the repo without the build being done.

[zooba]

New changeset 36b4f9e by Steve Dower in branch 'main':
bpo-43652: Actually update to Tcl/Tk 8.6.11 on Windows (GH-29397)
36b4f9e

[zooba]

New changeset 6340ba7 by Steve Dower in branch '3.10':
bpo-43652: Actually update to Tcl/Tk 8.6.11 on Windows (GH-29397)
6340ba7

[terryjreedy]

This worked for me on main and 3.10. Thanks.