Deprecation warnings in test_cmd_line and test_collections

[tirkarthi]

BPO	43825
Nosy	@vstinner, @tirkarthi
PRs	bpo-43825: Fix deprecation warnings in test cases #25380

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-04-14.11:46:55.729>
created_at = <Date 2021-04-13.05:15:15.825>
labels = ['type-bug', 'tests', '3.10']
title = 'Deprecation warnings in test_cmd_line and test_collections'
updated_at = <Date 2021-04-14.11:48:01.217>
user = 'https://github.com/tirkarthi'

bugs.python.org fields:

activity = <Date 2021-04-14.11:48:01.217>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2021-04-14.11:46:55.729>
closer = 'vstinner'
components = ['Tests']
creation = <Date 2021-04-13.05:15:15.825>
creator = 'xtreak'
dependencies = []
files = []
hgrepos = []
issue_num = 43825
keywords = ['patch']
message_count = 5.0
messages = ['390923', '391063', '391064', '391066', '391068']
nosy_count = 2.0
nosy_names = ['vstinner', 'xtreak']
pr_nums = ['25380']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue43825'
versions = ['Python 3.10']

[tirkarthi]

Following deprecation warnings are raised when tests are ran with -Wall in CPython test suite. I will raise a PR for this.

0:03:48 load avg: 0.79 [ 59/427] test_cmd_line
/root/cpython/Lib/test/test_cmd_line.py:865: DeprecationWarning: invalid escape sequence \u
self.check_string(b"'\u1f'")

0:04:11 load avg: 0.86 [ 77/427] test_collections
/root/cpython/Lib/test/test_collections.py:1518: DeprecationWarning: Please use assertEqual instead.
self.assertEquals(len(s), len(items) - 1)

[vstinner]

Serhiy closed my issue bpo-43841 as a duplicate of this one. My message:

Does someone want to propose a fix?

$ ./python -m test -v test_collections 
(...)
test_issue_4920 (test.test_collections.TestCollectionABCs) ... /home/vstinner/python/master/Lib/test/test_collections.py:1518: DeprecationWarning: Please use assertEqual instead.
  self.assertEquals(len(s), len(items) - 1)
ok
(...)
Tests result: SUCCESS

Warning introduced by PR 25209:

commit 453074c
Author: Stepan Sindelar <me@stevesindelar.cz>
Date: Thu Apr 8 01:31:55 2021 +0200

Fix broken test for MutableSet.pop() (GH-25209)

Changes the test to not assert concrete result of pop, but just that it
was an item from the set, and that the set shrunk by one.

[vstinner]

New changeset b8509ff by Karthikeyan Singaravelan in branch 'master':
bpo-43825: Fix deprecation warnings in test_cmd_line and test_collections (GH-25380)
b8509ff

[vstinner]

Thanks Karthikeyan! Usually, I let core developers to merge their own PRs, but I created multiple "easy" issues about warnings in tests, and so I merged directly your fix to prevent contributors to propose similar fixes ;-)

[vstinner]

I also created bpo-43839 "[easy] test_cmd_line: DeprecationWarning: invalid escape sequence \u" which was closed as duplicate of this one.