Some API methods could take const Py_buffer* instead of Py_buffer *

[DavidHewitt]

BPO	46140
Nosy	@serhiy-storchaka, @davidhewitt
PRs	bpo-46140: take more Py_buffer arguments as const * #30217

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2021-12-22.13:08:49.715>
created_at = <Date 2021-12-20.22:26:56.650>
labels = ['3.11']
title = 'Some API methods could take const Py_buffer* instead of Py_buffer *'
updated_at = <Date 2021-12-22.13:08:49.714>
user = 'https://github.com/davidhewitt'

bugs.python.org fields:

activity = <Date 2021-12-22.13:08:49.714>
actor = 'serhiy.storchaka'
assignee = 'none'
closed = True
closed_date = <Date 2021-12-22.13:08:49.715>
closer = 'serhiy.storchaka'
components = []
creation = <Date 2021-12-20.22:26:56.650>
creator = 'davidhewitt'
dependencies = []
files = []
hgrepos = []
issue_num = 46140
keywords = ['patch']
message_count = 3.0
messages = ['408976', '409032', '409033']
nosy_count = 2.0
nosy_names = ['serhiy.storchaka', 'davidhewitt']
pr_nums = ['30217']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue46140'
versions = ['Python 3.11']

[DavidHewitt]

The limited api methods PyBuffer_GetPointer, PyBuffer_FromContiguous, PyBuffer_ToContiguous and PyMemoryView_FromBuffer take buffer arguments as Py_buffer *.

They do not mutate the buffer info, so could simply take const Py_buffer *.

There is already precedent to take const Py_buffer * argument in PyBuffer_IsContiguous.

I'm going to submit a PR to fix.

[serhiy-storchaka]

New changeset 31ff967 by David Hewitt in branch 'main':
bpo-46140: take more Py_buffer arguments as const * (GH-30217)
31ff967

[serhiy-storchaka]

Thank you for your contribution David.