Makefile missing '/' for some path names

[gwolski]

BPO	46351
Nosy	@ronaldoussoren, @ned-deily, @zware, @gwolski

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2022-01-11.23:32:47.369>
labels = ['OS-mac', 'type-bug', 'expert-installation', '3.9', '3.10']
title = "Makefile missing '/' for some path names"
updated_at = <Date 2022-01-12.16:45:39.368>
user = 'https://github.com/gwolski'

bugs.python.org fields:

activity = <Date 2022-01-12.16:45:39.368>
actor = 'zach.ware'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Installation', 'macOS']
creation = <Date 2022-01-11.23:32:47.369>
creator = 'gwolski'
dependencies = []
files = []
hgrepos = []
issue_num = 46351
keywords = []
message_count = 2.0
messages = ['410356', '410413']
nosy_count = 4.0
nosy_names = ['ronaldoussoren', 'ned.deily', 'zach.ware', 'gwolski']
pr_nums = []
priority = 'normal'
resolution = None
stage = 'backport needed'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46351'
versions = ['Python 3.9', 'Python 3.10']

[gwolski]

In reviewing the output of make -n install, I notice certain paths are missing '/' separators:

if test "x" != "x" ; then \
rm -f /usr/local/python3.9.9/binpython3.9-32; \
lipo \
-output /usr/local/python3.9.9/bin/python3.9-32 \
/usr/local/python3.9.9/bin/python3.9; \
fi

There should be a '/' between bin and python3.9-32 and other lines have the same issue. The Makefile source lines where I see this error are:

    if test "x$(LIPO_32BIT_FLAGS)" != "x" ; then \\

--> rm -f $(DESTDIR)$(BINDIR)python$(VERSION)-32$(EXE); \
lipo $(LIPO_32BIT_FLAGS) \
-output $(DESTDIR)$(BINDIR)/python$(VERSION)-32$(EXE) \
$(DESTDIR)$(BINDIR)/python$(VERSION)$(EXE); \
fi
if test "x$(LIPO_INTEL64_FLAGS)" != "x" ; then \
--> rm -f $(DESTDIR)$(BINDIR)python$(VERSION)-intel64$(EXE); \
lipo $(LIPO_INTEL64_FLAGS) \
-output $(DESTDIR)$(BINDIR)/python$(VERSION)-intel64$(EXE) \
$(DESTDIR)$(BINDIR)/python$(VERSION)$(EXE); \
fi

I think the lines I've marked with --> above should have the '/' after $(BINDIR).... ????

[zware]

This has been fixed in 3.11 with #28659, but the fix hasn't been backported due to the unlikelihood of this issue actually being a problem and a procedural wrinkle in the original PR. I suspect a clean backport would be accepted, but this is still a rather low-priority issue.

[ronaldoussoren]

#28659 is the PR that fixed this in main (and was included in 3.11)

I don't think it is worthwhile to spend time on a back port for the 3.10 branch, especially as the procedural issue with the PR was that there's an invalid NEWS entry. I'm therefore closing the issue.