`'thread_time'` is missing from `test_get_clock_info`

[sobolevn]

BPO	46530
Nosy	@gvanrossum, @miss-islington, @sobolevn
PRs	bpo-46530: add "thread_time" to test_time.test_get_clock_info #30913 [3.9] bpo-46530: add "thread_time" to test_time.test_get_clock_info (GH-30913) #30977 [3.10] bpo-46530: add "thread_time" to test_time.test_get_clock_info (GH-30913) #30978

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2022-01-28.06:00:55.994>
created_at = <Date 2022-01-26.09:02:03.586>
labels = ['type-bug', 'tests', '3.9', '3.10', '3.11']
title = "`'thread_time'` is missing from `test_get_clock_info`"
updated_at = <Date 2022-01-28.16:56:57.217>
user = 'https://github.com/sobolevn'

bugs.python.org fields:

activity = <Date 2022-01-28.16:56:57.217>
actor = 'miss-islington'
assignee = 'none'
closed = True
closed_date = <Date 2022-01-28.06:00:55.994>
closer = 'sobolevn'
components = ['Tests']
creation = <Date 2022-01-26.09:02:03.586>
creator = 'sobolevn'
dependencies = []
files = []
hgrepos = []
issue_num = 46530
keywords = ['patch']
message_count = 5.0
messages = ['411717', '411976', '411977', '412013', '412014']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'miss-islington', 'sobolevn']
pr_nums = ['30913', '30977', '30978']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46530'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

[sobolevn]

Right now here's how test_get_clock_info looks like:

def test_get_clock_info(self):
        clocks = ['monotonic', 'perf_counter', 'process_time', 'time']

        for name in clocks:
            info = time.get_clock_info(name)

            #self.assertIsInstance(info, dict)
            self.assertIsInstance(info.implementation, str)
            self.assertNotEqual(info.implementation, '')
            self.assertIsInstance(info.monotonic, bool)
            self.assertIsInstance(info.resolution, float)
            # 0.0 < resolution <= 1.0
            self.assertGreater(info.resolution, 0.0)
            self.assertLessEqual(info.resolution, 1.0)
            self.assertIsInstance(info.adjustable, bool)

It tests for out of five possible arguments to time.get_clock_info.
Docs: https://docs.python.org/3/library/time.html#time.get_clock_info
'thread_time' is missing for some reason.

I think we should add it to the test.

Link:

cpython/Lib/test/test_time.py

Line 559 in 7cf285d

clocks = ['monotonic', 'perf_counter', 'process_time', 'time']

PR is incoming.

[gvanrossum]

New changeset c27a331 by Nikita Sobolev in branch 'main':
bpo-46530: add "thread_time" to test_time.test_get_clock_info (bpo-30913)
c27a331

[sobolevn]

Thank you!