Invalid cross device link in Lib/test/support/import_helper.py

[notarealdeveloper]

BPO	46678
Nosy	@brettcannon, @miss-islington, @notarealdeveloper
PRs	bpo-46678: Fix Invalid cross device link in Lib/test/support/import_helper.py #31204 [3.10] bpo-46678: Fix Invalid cross device link in Lib/test/support/import_helper.py (GH-31204) #31207

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2022-02-08.21:04:21.625>
created_at = <Date 2022-02-07.20:30:36.219>
labels = ['type-bug', 'tests', '3.10', '3.11']
title = 'Invalid cross device link in Lib/test/support/import_helper.py'
updated_at = <Date 2022-02-08.21:04:21.625>
user = 'https://github.com/notarealdeveloper'

bugs.python.org fields:

activity = <Date 2022-02-08.21:04:21.625>
actor = 'brett.cannon'
assignee = 'none'
closed = True
closed_date = <Date 2022-02-08.21:04:21.625>
closer = 'brett.cannon'
components = ['Tests']
creation = <Date 2022-02-07.20:30:36.219>
creator = 'notarealdeveloper'
dependencies = []
files = []
hgrepos = []
issue_num = 46678
keywords = ['patch']
message_count = 3.0
messages = ['412791', '412802', '412871']
nosy_count = 3.0
nosy_names = ['brett.cannon', 'miss-islington', 'notarealdeveloper']
pr_nums = ['31204', '31207']
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue46678'
versions = ['Python 3.10', 'Python 3.11']

[notarealdeveloper]

In Lib/test/support/import_helper.py, the function make_legacy_pyc makes a call to os.rename which can fail when the source and target live on different devices. This happens (for example) when PYTHONPYCACHEPREFIX is set to a directory on a different device from where temporary files are stored. Replacing os.rename with shutil.move fixes it. Will submit a PR.

[miss-islington]

New changeset da576e0 by Jason Wilkes in branch 'main':
bpo-46678: Fix Invalid cross device link in Lib/test/support/import_helper.py (GH-31204)
da576e0

[brettcannon]

New changeset c2735b7 by Miss Islington (bot) in branch '3.10':
bpo-46678: Fix Invalid cross device link in Lib/test/support/import_helper.py (GH-31204) (GH-31207)
c2735b7