Skip to content

bpo-36729: Delete unused text variable on tests #12959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 2 commits into from
Apr 29, 2019
+0 −4
Merged

bpo-36729: Delete unused text variable on tests #12959

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d9b74e
Delete unused text variable on tests
eamanu Apr 26, 2019
f6c19e8
Add one more unused variable
eamanu Apr 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions Lib/test/test_pydoc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1250,7 +1250,6 @@ def __get__(self, obj, cls):
class X:
attr = Descr()

text = pydoc.plain(pydoc.render_doc(X.attr))
Comment thread
eamanu marked this conversation as resolved.
self.assertEqual(self._get_summary_lines(X.attr), """\
<test.test_pydoc.TestDescriptions.test_custom_non_data_descriptor.<locals>.Descr object>""")

Expand All @@ -1276,17 +1275,14 @@ def __set__(self, obj, cls):
class X:
attr = Descr()

text = pydoc.plain(pydoc.render_doc(X.attr))
self.assertEqual(self._get_summary_lines(X.attr), "")

X.attr.__doc__ = 'Custom descriptor'
text = pydoc.plain(pydoc.render_doc(X.attr))
Comment thread
eamanu marked this conversation as resolved.
self.assertEqual(self._get_summary_lines(X.attr), """\
Custom descriptor
""")

X.attr.__name__ = 'foo'
text = pydoc.plain(pydoc.render_doc(X.attr))
self.assertEqual(self._get_summary_lines(X.attr), """\
foo
Custom descriptor
Expand Down