Skip to content

gh-141865: Fix translation of strings in changes.py extension #141882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2025
Merged

gh-141865: Fix translation of strings in changes.py extension #141882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Doc/tools/templates/dummy.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@

In extensions/changes.py:

{% trans %}Deprecated since version {deprecated}, will be removed in version {removed}{% endtrans %}
{% trans %}Deprecated since version {deprecated}, removed in version {removed}{% endtrans %}
{% trans %}Deprecated since version %s, will be removed in version %s{% endtrans %}
{% trans %}Deprecated since version %s, removed in version %s{% endtrans %}
Copy link
Member

@zware zware Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This precludes the possibility of a translation that needs to reorder the clauses. Not being a linguist I'm not certain that that's a necessity, but it seems well within the realm of possibility.

Copy link
Member Author

@StanFromIreland StanFromIreland Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be a possibility, however it may also be unnecessary. I think we should keep this simple fix for now, and if someone complains look into the hacky options.

Copy link
Member Author

@StanFromIreland StanFromIreland Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the languages on TX for the string, and all of them have the expected order.


In docsbuild-scripts, when rewriting indexsidebar.html with actual versions:

Expand Down
Loading