Skip to content

Conversation

@bdarnell
Copy link
Contributor

When the Windows default event loop changed, asyncio-policy.rst was updated but asyncio-eventloop.rst was missed.

When the Windows default event loop changed, `asyncio-policy.rst` was updated but `asyncio-eventloop.rst` was missed.
@bdarnell bdarnell requested review from 1st1 and asvetlov as code owners June 22, 2019 17:32
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot
Copy link

@1st1: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @bdarnell for the PR, and @1st1 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@1st1
Copy link
Member

1st1 commented Jun 22, 2019

Thank you!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 22, 2019
When the Windows default event loop changed, `asyncio-policy.rst` was updated but `asyncio-eventloop.rst` was missed.
(cherry picked from commit 9ffca67)

Co-authored-by: Ben Darnell <ben@bendarnell.com>
@bedevere-bot
Copy link

GH-14309 is a backport of this pull request to the 3.8 branch.

@bdarnell bdarnell deleted the patch-1 branch June 22, 2019 17:51
miss-islington added a commit that referenced this pull request Jun 24, 2019
When the Windows default event loop changed, `asyncio-policy.rst` was updated but `asyncio-eventloop.rst` was missed.
(cherry picked from commit 9ffca67)

Co-authored-by: Ben Darnell <ben@bendarnell.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
When the Windows default event loop changed, `asyncio-policy.rst` was updated but `asyncio-eventloop.rst` was missed.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
When the Windows default event loop changed, `asyncio-policy.rst` was updated but `asyncio-eventloop.rst` was missed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants