Skip to content

[3.8] asyncio: Fix docs for default event loop (GH-14308) #14309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2019
Merged

[3.8] asyncio: Fix docs for default event loop (GH-14308) #14309

merged 1 commit into from
Jun 24, 2019

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jun 22, 2019

When the Windows default event loop changed, asyncio-policy.rst was updated but asyncio-eventloop.rst was missed.
(cherry picked from commit 9ffca67)

Co-authored-by: Ben Darnell ben@bendarnell.com

@bdarnell @miss-islington
asyncio: Fix docs for default event loop (pythonGH-14308)
5f880f4 
When the Windows default event loop changed, `asyncio-policy.rst` was updated but `asyncio-eventloop.rst` was missed.
(cherry picked from commit 9ffca67)

Co-authored-by: Ben Darnell <ben@bendarnell.com>
@bedevere-bot bedevere-bot mentioned this pull request Jun 22, 2019
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented Jun 22, 2019

@bdarnell and @1st1: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

miss-islington commented Jun 22, 2019

@bdarnell and @1st1: Status check is done, and it's a success ✅ .

willingc
willingc approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@miss-islington miss-islington merged commit 2e0ec5b into python:3.8 Jun 24, 2019
@miss-islington miss-islington deleted the backport-9ffca67-3.8 branch June 24, 2019 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willingc willingc willingc approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@miss-islington @willingc @the-knights-who-say-ni @bedevere-bot @bdarnell