gh-62259: Add support of multi-byte encodings in the XML parser#149860
Open
serhiy-storchaka wants to merge 2 commits into
Open
gh-62259: Add support of multi-byte encodings in the XML parser#149860serhiy-storchaka wants to merge 2 commits into
serhiy-storchaka wants to merge 2 commits into
Conversation
Supported encodings: "cp932", "cp949", "cp950", "Big5","EUC-JP", "GB2312", "GBK", "johab", and "Shift_JIS". Partially supported encodings (only BMP characters): "Big5-HKSCS", "EUC_JIS-2004", "EUC_JISX0213", "Shift_JIS-2004", "Shift_JISX0213", "utf-8-sig" and non-standard aliases like "UTF8" (without hyphen). The parser now raises ValueError for known unsupported multi-byte encodings such us "ISO-2022-JP" or "raw-unicode-escape" instead of failing later, when encounter non-ASCII data.
Documentation build overview
|
malemburg
approved these changes
May 15, 2026
Member
malemburg
left a comment
malemburg
left a comment
There was a problem hiding this comment.
LGTM.
The only detail that is missing is the documentation update. This still reads "UTF-8, UTF-16, ISO-8859-1 (Latin1), and ASCII" which already appears to be out of date.
| be extended; it supports UTF-8, UTF-16, ISO-8859-1 (Latin1), and ASCII. If | ||
| *encoding* [1]_ is given it will override the implicit or explicit encoding of the | ||
| document. | ||
| must be a string naming the encoding used by the XML data. |
Member
There was a problem hiding this comment.
Suggested change
| must be a string naming the encoding used by the XML data. | |
| must be a string naming the encoding used by the XML data. |
| *encoding* [1]_ is given it will override the implicit or explicit encoding of the | ||
| document. | ||
| must be a string naming the encoding used by the XML data. | ||
| Expat natively understands and processes UTF-8, UTF-16, UTF-16BE, UTF-16LE, |
Member
There was a problem hiding this comment.
I think this should be an .. impl-detail (I don't remember the exact name)?
| --- | ||
|
|
||
| * TODO | ||
| * Add support of multiple multi-byte encodings in the :mod:`XML parser |
Member
There was a problem hiding this comment.
Suggested change
| * Add support of multiple multi-byte encodings in the :mod:`XML parser | |
| * Add support for multiple multi-byte encodings in the :mod:`XML parser |
| @@ -0,0 +1,9 @@ | |||
| Add support of multiple multi-byte encodings in the :mod:`XML parser | |||
Member
There was a problem hiding this comment.
Suggested change
| Add support of multiple multi-byte encodings in the :mod:`XML parser | |
| Add support for multiple multi-byte encodings in the :mod:`XML parser |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supported encodings: "cp932", "cp949", "cp950", "Big5","EUC-JP", "GB2312", "GBK", "johab", and "Shift_JIS".
Partially supported encodings (only BMP characters): "Big5-HKSCS", "EUC_JIS-2004", "EUC_JISX0213", "Shift_JIS-2004", "Shift_JISX0213", "utf-8-sig" and non-standard aliases like "UTF8" (without hyphen).
The parser now raises ValueError for known unsupported multi-byte encodings such us "ISO-2022-JP" or "raw-unicode-escape" instead of failing later, when encounter non-ASCII data.