gh-153419: Fix several issues around bytearray __init__#153498
Open
stestagg wants to merge 1 commit into
Open
Conversation
Introduce a bytearray_new function to ensure that
ob_bytes_object is always set on a bytearray.
Resizing a bytearray to 0 length explicitly sets
the ob_bytes_object to the empty constant immortal.
Add a check in the 'bytearray init from string'
fast path to ensure there are no active exports.
This fixes asserts/crashes on the following:
- bytearray(1).__init__()
- bytearray().__new__(bytearray).append(1)
- a = bytearray(); b = memoryview(a); a.__init__('x', 'ascii')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a bytearray_new function to ensure that
ob_bytes_object is always set on a bytearray.
Resizing a bytearray to 0 length explicitly sets
the ob_bytes_object to the empty constant immortal.
Add a check in the 'bytearray init from string'
fast path to ensure there are no active exports.
This fixes asserts/crashes on the following:
bytearray(1).__init__()bytearray().__new__(bytearray).append(1)a = bytearray(); b = memoryview(a); a.__init__('x', 'ascii')I realise that the explicit setting of bytes_object to
Py_CONSTANT_EMPTY_BYTESis not strictly necessary, as this is also done by the_PyBytes_Resizetoo, but this seemed to mark the intent of what's happening more clearly, given we rely and assert on that exact behaviour.