gh-153658: sqlite3.Connection.iterdump() fails for names with single quote#153666
Closed
joshiaradhya wants to merge 2 commits into
Closed
gh-153658: sqlite3.Connection.iterdump() fails for names with single quote#153666joshiaradhya wants to merge 2 commits into
joshiaradhya wants to merge 2 commits into
Conversation
…entifiers embedded in string literals\n\nProperly double single quotes when embedding a double-quoted identifier into a single-quoted SQL string literal so table/column names with apostrophes round-trip.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
…gment for bpo-153658 so the change is recorded in Misc/NEWS.d.
erlend-aasland
changed the title
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #153658 by escaping single quotes when emitting identifiers inside single-quoted SQL string literals in sqlite3.Connection.iterdump().\n\nChanges:\n- Lib/sqlite3/dump.py: double single quotes for the identifier when embedded into a string literal (keep double-quoted identifier for PRAGMA/FROM).\n- Lib/test/test_sqlite3/test_dump.py: added tests for table names containing single and double quotes.\n\nAll local DumpTests pass.\n\nFixes #153658