gh-153853: Fix parameter name of calendar.setfirstweekday() in docs#153851
Merged
Conversation
Documentation build overview
|
brettcannon
approved these changes
Jul 17, 2026
|
Thanks @IbrahimShaqqou for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-153859 is a backport of this pull request to the 3.15 branch. |
|
GH-153861 is a backport of this pull request to the 3.13 branch. |
|
GH-153860 is a backport of this pull request to the 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module-level function is documented as
setfirstweekday(weekday), but the implementation inLib/calendar.pyisdef setfirstweekday(firstweekday). The parameter can be passed by keyword, so the documented signature fails:This also makes the entry consistent with
Calendar.setfirstweekday(firstweekday)documented earlier in the same file, and with theCalendar(firstweekday=0)constructor and thecalendar.firstweekday()accessor.Docs-only change; per the contributing guidelines, no issue for trivial fixes (skip issue).