Skip to content

Improve calendar constants deprecation coverage#153893

Merged
tomasr8 merged 3 commits into
python:mainfrom
vjabuilds:improve-calendar-constants-deprecation-coverage
Jul 18, 2026
Merged

Improve calendar constants deprecation coverage#153893
tomasr8 merged 3 commits into
python:mainfrom
vjabuilds:improve-calendar-constants-deprecation-coverage

Conversation

@vjabuilds

@vjabuilds vjabuilds commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

The calendar.February and calendar.January constants were both deprecated, while Lib/test/test_calendar.py only checked if a DeprecationWarning was issued for calendar.January.

Extended the test to include calendar.February in the deprecation check as well.

vjabuilds added 2 commits July 18, 2026 10:38
@vjabuilds
Calendar related tests now check if both deprecated constants surface…
bc80289 
… the proper warnings.

* extended `test_deprecation_warning` to check `constants.February` as well
@vjabuilds
Merge remote-tracking branch 'upstream/main' into improve-calendar-co…
2f8e517 
…nstants-deprecation-coverage
@vjabuilds
vjabuilds requested a review from AA-Turner as a code owner July 18, 2026 08:50
@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jul 18, 2026
@python-cla-bot

python-cla-bot Bot commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@github-project-automation github-project-automation Bot moved this to Todo in Sprint Jul 18, 2026
@tomasr8

tomasr8 commented Jul 18, 2026

Copy link
Copy Markdown
Member

One of the Windows tests is failing which seems unrelated to the change, let's see if re-running the tests fixes it

@vjabuilds

vjabuilds commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

One of the Windows tests is failing which seems unrelated to the change, let's see if re-running the tests fixes it

Thanks a lot for looking into it

tomasr8
tomasr8 approved these changes Jul 18, 2026
View reviewed changes

@tomasr8 tomasr8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @vjabuilds !

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Sprint Jul 18, 2026
@tomasr8 tomasr8 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 18, 2026
@tomasr8
tomasr8 merged commit 31c81e6 into python:main Jul 18, 2026
58 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Sprint Jul 18, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Thanks @vjabuilds for the PR, and @tomasr8 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-153919 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 18, 2026
@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-153920 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 18, 2026
@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-153921 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 18, 2026
tomasr8 added a commit that referenced this pull request Jul 18, 2026
@miss-islington @vjabuilds @tomasr8
[3.15] Test calendar.February deprecation (GH-153893) (#153919)
e09f49e 
Test `calendar.February` deprecation (GH-153893)

Calendar related tests now check if both deprecated constants surface the proper warnings.

* extended `test_deprecation_warning` to check `constants.February` as well
(cherry picked from commit 31c81e6)

Co-authored-by: vjabuilds <77214151+vjabuilds@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
tomasr8 added a commit that referenced this pull request Jul 18, 2026
@miss-islington @vjabuilds @tomasr8
[3.14] Test calendar.February deprecation (GH-153893) (#153920)
6f0f2cf 
Test `calendar.February` deprecation (GH-153893)

Calendar related tests now check if both deprecated constants surface the proper warnings.

* extended `test_deprecation_warning` to check `constants.February` as well
(cherry picked from commit 31c81e6)

Co-authored-by: vjabuilds <77214151+vjabuilds@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
tomasr8 added a commit that referenced this pull request Jul 18, 2026
@miss-islington @vjabuilds @tomasr8
[3.13] Test calendar.February deprecation (GH-153893) (#153921)
bf5f85d 
Test `calendar.February` deprecation (GH-153893)

Calendar related tests now check if both deprecated constants surface the proper warnings.

* extended `test_deprecation_warning` to check `constants.February` as well
(cherry picked from commit 31c81e6)

Co-authored-by: vjabuilds <77214151+vjabuilds@users.noreply.github.com>
Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasr8 tomasr8 tomasr8 approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

skip issue skip news sprint tests Tests in the Lib/test dir

Projects

Sprint
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vjabuilds @tomasr8 @encukou