Skip to content

gh-71896: warn in doc about trailing newlines ignored by HtmlDiff#153930

Merged
ZeroIntensity merged 3 commits into
python:mainfrom
Lenormju:gh-71896-warn-about-bug-in-htmldiff
Jul 18, 2026
Merged

gh-71896: warn in doc about trailing newlines ignored by HtmlDiff#153930
ZeroIntensity merged 3 commits into
python:mainfrom
Lenormju:gh-71896-warn-about-bug-in-htmldiff

Conversation

@Lenormju

@Lenormju Lenormju commented Jul 18, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app bedevere-app Bot mentioned this pull request Jul 18, 2026
Open
@github-project-automation github-project-automation Bot moved this to Todo in Sprint Jul 18, 2026
@chris-eibl
chris-eibl requested a review from encukou July 18, 2026 11:54
@read-the-docs-community

read-the-docs-community Bot commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33646212 | 📁 Comparing 368fd1e against main (bc2fd44)

  🔍 Preview build  

9 files changed · ± 9 modified

± Modified

@Lenormju

Lenormju commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

I have added a NEWS item after discussing with Chris, because it is not only a documentation change but also a new test and a comment in the actual Lib code.

@ZeroIntensity

ZeroIntensity commented Jul 18, 2026

Copy link
Copy Markdown
Member

I don't think this needs a news entry as there's no behavior change here. We don't add changelog entries for new tests, so let's remove the blurb here. I discussed this with Chris as well, and he agrees.

@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Lenormju

Lenormju commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

@ZeroIntensity I removed it

@ZeroIntensity ZeroIntensity added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 18, 2026
ZeroIntensity
ZeroIntensity approved these changes Jul 18, 2026
View reviewed changes

@ZeroIntensity ZeroIntensity left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Sprint Jul 18, 2026
@ZeroIntensity
ZeroIntensity enabled auto-merge (squash) July 18, 2026 13:21
@ZeroIntensity
ZeroIntensity merged commit 755d971 into python:main Jul 18, 2026
66 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Sprint Jul 18, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Thanks @Lenormju for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-153965 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 18, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Sorry, @Lenormju and @ZeroIntensity, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 755d97167f6f5d4361c790f8f18df76cae8f2ad2 3.13

@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-153966 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 18, 2026
@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-153968 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 18, 2026
ZeroIntensity pushed a commit that referenced this pull request Jul 18, 2026
@miss-islington @Lenormju
[3.15] gh-71896: Add a docs warning about trailing newlines ignored b…
b6a140b 
…y `difflib.HtmlDiff` (GH-153930) (GH-153965)

(cherry picked from commit 755d971)

Co-authored-by: Lenormand Julien <lenormand.julien0@gmail.com>
ZeroIntensity added a commit that referenced this pull request Jul 18, 2026
@ZeroIntensity @Lenormju
[3.13] gh-71896: Add a docs warning about trailing newlines ignored b…
75b6789 
…y `difflib.HtmlDiff` (GH-153930) (GH-153968)

(cherry picked from commit 755d971)

Co-authored-by: Lenormand Julien <lenormand.julien0@gmail.com>
ZeroIntensity pushed a commit that referenced this pull request Jul 18, 2026
@miss-islington @Lenormju
[3.14] gh-71896: Add a docs warning about trailing newlines ignored b…
1f3814f 
…y `difflib.HtmlDiff` (GH-153930) (GH-153966)

(cherry picked from commit 755d971)

Co-authored-by: Lenormand Julien <lenormand.julien0@gmail.com>
@Lenormju
Lenormju deleted the gh-71896-warn-about-bug-in-htmldiff branch July 18, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes
@encukou encukou Awaiting requested review from encukou

Assignees

@ZeroIntensity ZeroIntensity

Labels

skip news sprint

Projects

Sprint
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Lenormju @ZeroIntensity @chris-eibl