Skip to content

Add test coverage to check execution of GetoptError.__str__#153941

Merged
tomasr8 merged 10 commits into
python:mainfrom
manith-hetti:increase_getopt_test_cov
Jul 18, 2026
Merged

Add test coverage to check execution of GetoptError.__str__#153941
tomasr8 merged 10 commits into
python:mainfrom
manith-hetti:increase_getopt_test_cov

Conversation

@manith-hetti

@manith-hetti manith-hetti commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jul 18, 2026
@python-cla-bot

python-cla-bot Bot commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@manith-hetti manith-hetti changed the title Add test coverage to getopt to check execution of GetoptError.__str__ Add test coverage to check execution of GetoptError.__str__ Jul 18, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Sprint Jul 18, 2026
@tomasr8

tomasr8 commented Jul 18, 2026

Copy link
Copy Markdown
Member

Thanks for the PR @manith-hetti ! Could you please restore the formatting changes?

@tomasr8

tomasr8 commented Jul 18, 2026

Copy link
Copy Markdown
Member

I think one test case is enough. We just want to make sure __str__ is executed, so no need for multiple tests :)

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in Sprint Jul 18, 2026
@tomasr8
tomasr8 enabled auto-merge (squash) July 18, 2026 14:27
@tomasr8 tomasr8 added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 18, 2026
@tomasr8 tomasr8 added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 18, 2026
@tomasr8
tomasr8 merged commit 9adef68 into python:main Jul 18, 2026
54 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Sprint Jul 18, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

Thanks @manith-hetti for the PR, and @tomasr8 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-153997 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 18, 2026
@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-153998 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 18, 2026
@bedevere-app

bedevere-app Bot commented Jul 18, 2026

Copy link
Copy Markdown

GH-154000 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 18, 2026
tomasr8 pushed a commit that referenced this pull request Jul 18, 2026
@miss-islington @manith-hetti
[3.13] Add test coverage to check execution of GetoptError.__str__ (G…
bf5ffa3 
…H-153941) (#154000)

Add test coverage to check execution of GetoptError.__str__ (GH-153941)

* Increase test coverage of getopt to check execution of GetoptError.__str__

* Add test coverage to check execution of GetoptError.__str__

* Add test coverage to check execution of GetoptError.__str__

* Add test coverage to check execution of GetoptError.__str__

* Add test coverage to check execution of GetoptError.__str__

* Add test coverage to check execution of GetoptError.__str__
(cherry picked from commit 9adef68)

Co-authored-by: Manith Hettiarachchilage <manithhetti@gmail.com>
tomasr8 pushed a commit that referenced this pull request Jul 18, 2026
@miss-islington @manith-hetti
[3.14] Add test coverage to check execution of GetoptError.__str__ (G…
02a91ea 
…H-153941) (#153998)

Add test coverage to check execution of GetoptError.__str__ (GH-153941)

* Increase test coverage of getopt to check execution of GetoptError.__str__

* Add test coverage to check execution of GetoptError.__str__

* Add test coverage to check execution of GetoptError.__str__

* Add test coverage to check execution of GetoptError.__str__

* Add test coverage to check execution of GetoptError.__str__

* Add test coverage to check execution of GetoptError.__str__
(cherry picked from commit 9adef68)

Co-authored-by: Manith Hettiarachchilage <manithhetti@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

Assignees

No one assigned

Labels

skip issue skip news sprint tests Tests in the Lib/test dir

Projects

Sprint
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@manith-hetti @tomasr8 @encukou