gh-104533: Fix @ctypes.util.struct with string annotations#154040
Merged
Conversation
Fix @ctypes.util.struct on structures declared in a module which uses "from __future__ import annotations". The decorator now calls get_annotations() with eval_str=True.
Member
Author
|
With this change, the following example: from ctypes.util import struct
@struct
class Point:
x: 'invalid_name'now fails with The traceback starts on line 3 of |
vstinner
commented
Jul 19, 2026
| def test_string_annotations(self): | ||
| from test.test_ctypes import struct_str_ann | ||
| Point = struct_str_ann.Point | ||
| fields = [['x', c_int], ['y', c_int]] |
Member
Author
There was a problem hiding this comment.
This line should be updated if PR gh-154038 is merged first.
Member
Author
There was a problem hiding this comment.
Crap. I missed my own comment when I merged this PR, and now the pre-commit CI fails on the main branch :-( I wrote #154091 to fix the CI.
Member
Author
Member
Author
|
I found this bug while trying to convert |
Member
Author
|
|
ZeroIntensity
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
@ctypes.util.structon structures declared in a module which usesfrom __future__ import annotations. The decorator now calls get_annotations() with eval_str=True.