gh-154090: Store profiling mode in binary files#154105
Open
pablogsal wants to merge 2 commits into
Open
Conversation
pablogsal
added
the
needs backport to 3.15
Member
Author
|
CC: @lkollar |
maurycy
reviewed
Jul 20, 2026
Contributor
There was a problem hiding this comment.
What about threads (ie: main v. --all-threads; now implicit from HDR_OFF_THREADS), native_frames, gc for diffs?
Truth be told, I wonder about the all flags (especially if we strictly care about honest diffs and replays), about describing the target (especially for Gecko), but also about error rate, maybe even failed samples (ref #154092).
That's a bit of a Whac-A-Mole without approaching this is in a bit more generic way (eg: flexible metadata struct within the existing header.)
| | 44 | 8 | uint64 | Frame table offset | | ||
| | 52 | 4 | uint32 | Compression type (0=none, 1=zstd) | | ||
| | 56 | 8 | bytes | Reserved (zero-filled) | | ||
| | 28 | 8 | uint64 | Total sample count | |
Comment on lines
+94
to
+95
| Profiling modes use their `_remote_debugging.PROFILING_MODE_*` value plus one, | ||
| leaving zero available for binaries written before this field was defined. |
Contributor
There was a problem hiding this comment.
Do we care about backwards compatibility that much, given that we have recently changed the total sample count from uint32 to uint64 lately (#153425)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #154090.