gh-154260: Fix test_flush_parameters on DragonFly BSD#154261
Merged
serhiy-storchaka merged 1 commit intoJul 20, 2026
Conversation
DragonFly, like FreeBSD, rejects mmap.flush() with MS_ASYNC|MS_INVALIDATE (EINVAL). Use str.startswith() so the check also matches DragonFly, whose sys.platform carries a version suffix. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
serhiy-storchaka
added
needs backport to 3.13
serhiy-storchaka
enabled auto-merge (squash)
July 20, 2026 14:07
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
Sorry, @serhiy-storchaka, I could not cleanly backport this to |
|
GH-154269 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
serhiy-storchaka
removed
needs backport to 3.13
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 20, 2026
…) (GH-154269) DragonFly, like FreeBSD, rejects mmap.flush() with MS_ASYNC|MS_INVALIDATE (EINVAL). Use str.startswith() so the check also matches DragonFly, whose sys.platform carries a version suffix. (cherry picked from commit fc4d93d) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DragonFly BSD, like FreeBSD, rejects
mmap.flush()withMS_ASYNC | MS_INVALIDATE(EINVAL). The test special-cased this only forsys.platform == 'freebsd', but DragonFly'ssys.platformis'dragonfly6', so it took the else branch expecting success. Usesys.platform.startswith(('freebsd', 'dragonfly')), which also future-proofs the FreeBSD match against a versionedsys.platform.Verified on DragonFly 6 (now passes), FreeBSD and Linux (unaffected).
🤖 Generated with Claude Code