gh-145868: Suggest names on typos in __future__ imports#154347
Open
sobolevn wants to merge 2 commits into
Open
gh-145868: Suggest names on typos in __future__ imports#154347sobolevn wants to merge 2 commits into
__future__ imports#154347sobolevn wants to merge 2 commits into
Conversation
picnixz
reviewed
Jul 22, 2026
| #define FUTURE_BARRY_AS_BDFL "barry_as_FLUFL" | ||
| #define FUTURE_GENERATOR_STOP "generator_stop" | ||
| #define FUTURE_ANNOTATIONS "annotations" | ||
| #define FUTURE_BRACES "braces" |
Member
There was a problem hiding this comment.
It may seem silly but can you put that define in its historical addition? like when did we add that future? I do not know though if the defines are sorted (but annotations is definitely the last one being added IIRC)
Member
Author
There was a problem hiding this comment.
I would prefer to keep it sorted the same way it is in future.c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from __future__ import#145868