gh-93251: Decode localized socket error messages from the locale encoding#154683
Merged
Merged
Conversation
…e encoding The gai_strerror() and hstrerror() messages were decoded as UTF-8, so gaierror and herror could be replaced with UnicodeDecodeError if the message is localized and the locale encoding is not UTF-8. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15. |
|
GH-154723 is a backport of this pull request to the 3.15 branch. |
bedevere-app
Bot
removed
the
needs backport to 3.15
|
GH-154724 is a backport of this pull request to the 3.14 branch. |
|
GH-154725 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 26, 2026
…le encoding (GH-154683) (GH-154724) The gai_strerror() and hstrerror() messages were decoded as UTF-8, so gaierror and herror could be replaced with UnicodeDecodeError if the message is localized and the locale encoding is not UTF-8. (cherry picked from commit 5afbb60) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 26, 2026
…le encoding (GH-154683) (GH-154723) The gai_strerror() and hstrerror() messages were decoded as UTF-8, so gaierror and herror could be replaced with UnicodeDecodeError if the message is localized and the locale encoding is not UTF-8. (cherry picked from commit 5afbb60) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
serhiy-storchaka
added a commit
that referenced
this pull request
Jul 26, 2026
…le encoding (GH-154683) (GH-154725) The gai_strerror() and hstrerror() messages were decoded as UTF-8, so gaierror and herror could be replaced with UnicodeDecodeError if the message is localized and the locale encoding is not UTF-8. (cherry picked from commit 5afbb60) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
gai_strerror()andhstrerror()messages were decoded as UTF-8, sogaierrorandherrorcould be replaced withUnicodeDecodeErrorif the message is localized and the locale encoding is not UTF-8. Decode them from the locale encoding with the "surrogateescape" error handler.Reproduced with the Ukrainian KOI8-U locale on Linux and the Japanese EUC-JP locale on FreeBSD (where it also made
test_loggingfail). The new test runs under a number of locales with non-ASCII localized messages, at least one of which is available on each of Linux, FreeBSD, NetBSD, DragonFly BSD, OpenIndiana and macOS.