Skip to content

Fix a stale link for the math.integer.isqrt correctness proof#154685

Merged
StanFromIreland merged 3 commits into
python:mainfrom
mdickinson:fix-stale-isqrt-proof-link
Jul 25, 2026
Merged

Fix a stale link for the math.integer.isqrt correctness proof#154685
StanFromIreland merged 3 commits into
python:mainfrom
mdickinson:fix-stale-isqrt-proof-link

Conversation

@mdickinson

Copy link
Copy Markdown
Member

The math.integer C source contains a link to an old proof of correctness for the math.integer.isqrt algorithm. That old proof, written in the obsolete language Lean 3, no longer exists at the given URL. This PR:

  • updates the URL to point to the current proof, written in Lean 4
  • removes the "an equivalent recursive algorithm" hedge, since the Lean 4 proof directly proves correctness of the iterative form of the algorithm

I didn't create an issue for this trivial comment-only change. Let me know if you think it needs one.

@mdickinson

mdickinson commented Jul 25, 2026

Copy link
Copy Markdown
Member Author

I updated the URL to use a permalink, to reduce the likelihood of the link breaking in the future. There's a tradeoff here: Lean 4 evolves fairly rapidly, so there's a risk that the permalink version will eventually not compile. (The project locks the version of Lean 4 that it builds against, so the build won't break purely because a new version of Lean 4 with backwards-incompatible changes has been released. But there are other possible evolutionary failure modes.)

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanFromIreland StanFromIreland added docs Documentation in the Doc dir skip issue skip news labels Jul 25, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jul 25, 2026
@StanFromIreland
StanFromIreland merged commit b86a41c into python:main Jul 25, 2026
60 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jul 25, 2026
@StanFromIreland StanFromIreland added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 25, 2026
@miss-islington-app

Copy link
Copy Markdown

Thanks @mdickinson for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 25, 2026

Copy link
Copy Markdown

GH-154698 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 25, 2026
@StanFromIreland

Copy link
Copy Markdown
Member

Earlier backports will have to be done manually.

StanFromIreland pushed a commit that referenced this pull request Jul 25, 2026
…of (GH-154685) (#154698)

(cherry picked from commit b86a41c)

Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants