Fix a stale link for the math.integer.isqrt correctness proof#154685
Merged
StanFromIreland merged 3 commits intoJul 25, 2026
Conversation
Member
Author
|
I updated the URL to use a permalink, to reduce the likelihood of the link breaking in the future. There's a tradeoff here: Lean 4 evolves fairly rapidly, so there's a risk that the permalink version will eventually not compile. (The project locks the version of Lean 4 that it builds against, so the build won't break purely because a new version of Lean 4 with backwards-incompatible changes has been released. But there are other possible evolutionary failure modes.) |
|
Thanks @mdickinson for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-154698 is a backport of this pull request to the 3.15 branch. |
Member
|
Earlier backports will have to be done manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
math.integerC source contains a link to an old proof of correctness for themath.integer.isqrtalgorithm. That old proof, written in the obsolete language Lean 3, no longer exists at the given URL. This PR:I didn't create an issue for this trivial comment-only change. Let me know if you think it needs one.