gh-154719: Preserve trailing whitespace in t-string interpolation expressions#154736
Open
lpyu001 wants to merge 1 commit into
Open
gh-154719: Preserve trailing whitespace in t-string interpolation expressions#154736lpyu001 wants to merge 1 commit into
lpyu001 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Interpolation.expressionpreserved whitespace after the opening{, but removed whitespace immediately before},!, or:. This was inconsistent with the documented behavior of preserving the expression text inside the braces.Root cause
The lexer metadata already contained the trailing whitespace, but the parser unconditionally stripped trailing whitespace from every interpolation expression while handling debug expressions.
Solution
Preserve the lexer metadata unchanged for regular interpolations. For self-documenting expressions, remove only the debug
=and whitespace after it, while preserving whitespace before it. Add tests covering regular, converted, formatted, debug, comparison, and multiline expressions.