[3.15] gh-135736: Fix interaction between TaskGroup and aclose() (GH-154649) - #154900
Open
miss-islington wants to merge 1 commit into
Open
[3.15] gh-135736: Fix interaction between TaskGroup and aclose() (GH-154649)#154900miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
…onGH-154649) Currently if you have a generator like: ``` async def test(): async with asyncio.TaskGroup() as tg: async for x in whatever(): yield x ``` If aclose() is called on the generator and GeneratorExit is raised, the TaskGroup's __aexit__ will raise a BaseExceptionGroup, and that will be raised from the aclose() call instead of it being swallowed. Fix this by raising GeneratorExit from __aexit__ when: 1. The body of task group raised it 2. No subtasks raised exceptions This makes GeneratorExit work without swallowing other exceptions (like it would if we just added it to _is_base_error). (cherry picked from commit 49f9667) Co-authored-by: Michael J. Sullivan <sully@msully.net>
miss-islington
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
July 29, 2026 21:09
This was referenced Jul 29, 2026
Documentation build overview
306 files changed ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you have a generator like:
If aclose() is called on the generator and GeneratorExit is raised,
the TaskGroup's aexit will raise a BaseExceptionGroup, and that
will be raised from the aclose() call instead of it being swallowed.
Fix this by raising GeneratorExit from aexit when:
This makes GeneratorExit work without swallowing other exceptions
(like it would if we just added it to _is_base_error).
(cherry picked from commit 49f9667)
Co-authored-by: Michael J. Sullivan sully@msully.net