gh-154936: Fix JSON control character error position - #154941
Open
yangbaechu wants to merge 1 commit into
Open
Conversation
Report the index of the invalid literal control character instead of the following index in the pure Python decoder.
|
All commit authors signed the Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #154936.
Report the actual position of invalid literal control characters in the pure Python JSON decoder. Previously, the scanner passed
Match.end(), which points one character past the consumed control character, causingJSONDecodeError.pos,lineno, andcolnoto identify the following character instead.Use
end - 1only in the strict invalid-control-character branch and extend the existing ASCII control-character test to verify all three location attributes for U+0000 through U+001F. The shared JSON tests cover both the pure Python and C decoders.Tests
./python -m test test_jsonmake patchcheck