gh-59091: Align pure-Python JSON container handling with C - #155080
Closed
Taeknology wants to merge 1 commit into
Closed
gh-59091: Align pure-Python JSON container handling with C#155080Taeknology wants to merge 1 commit into
Taeknology wants to merge 1 commit into
Conversation
Use actual type ancestry for list, tuple, dict, and frozendict dispatch in the pure-Python encoder. This prevents objects that only spoof __class__ from bypassing JSONEncoder.default(), while preserving real container subclasses.
Member
|
There was no prior discussion/update for the past 8y. We need to wonder whether the issue is still relevant and possibly decide on how to do it. So I am closing this premature PR. For longstanding issues, please wait for maintainers to confirm how relevant they are and the direction to take. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59091.
What changed
The pure-Python
jsonencoder now uses an object's actual type hierarchy when dispatchinglist,tuple,dict, andfrozendictvalues, matching the C accelerator. Objects that only spoof__class__are routed through the encoder'sdefault()handler instead of being treated as containers.Genuine subclasses of the supported container types continue to be encoded normally.
Tests
Added shared pure-Python/C regression coverage for top-level and nested spoofed objects, plus genuine container subclasses.
test_json.test_defaultand the fulltest_jsonsuite pass locally.