gh-155102: Preserve TypeError raised during set discard/remove comparison - #155104
Closed
BHUVANSH855 wants to merge 2 commits into
Closed
gh-155102: Preserve TypeError raised during set discard/remove comparison#155104BHUVANSH855 wants to merge 2 commits into
BHUVANSH855 wants to merge 2 commits into
Conversation
Member
|
See my comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue gh-155102.
set.discard()andset.remove()could incorrectly suppress or replaceexceptions raised during equality comparison when the lookup key was a
hashable subclass of
set.The issue was caused by the special set/frozenset fallback path treating
all
TypeErrorcases from hashing as unhashable-key handling. This couldclear an exception raised by
__eq__and retry the lookup, resulting indifferent behavior compared to normal membership testing.
This change separates the hash failure path from comparison errors:
set/frozensetkeys.
set.discard()andset.remove().A regression test has been added to cover a hashable
setsubclass whose__eq__raisesTypeError.Tests:
./python -m test test_set