gh-155176: Don't track frozendicts whose contents can never be tracked by the GC - #155178
Open
aisk wants to merge 1 commit into
Open
gh-155176: Don't track frozendicts whose contents can never be tracked by the GC#155178aisk wants to merge 1 commit into
aisk wants to merge 1 commit into
Conversation
…tracked by the GC
| self.assertFalse(gc.is_tracked(frozendict.fromkeys('ab', 1))) | ||
| self.assertFalse(gc.is_tracked(frozendict({1: 2}) | {3: 4})) | ||
|
|
||
| self.assertTrue(gc.is_tracked(frozendict({1: [2]}))) |
Contributor
There was a problem hiding this comment.
What do you think is it worth to add a test with {1: (2,)}?
And maybe it is worth to add tests with gc-tracked keys and gc-not-tracked values?
sobolevn
reviewed
Aug 4, 2026
| # subclasses can create reference cycles, they are always tracked | ||
| self.assertTrue(gc.is_tracked(FrozenDict({1: 2}))) | ||
|
|
||
| # a reference cycle through a tracked frozendict is collectable |
Member
There was a problem hiding this comment.
I would make this a separate test.
| self.assertFalse(gc.is_tracked(frozendict())) | ||
| self.assertFalse(gc.is_tracked(frozendict({1: 2}))) | ||
| self.assertFalse(gc.is_tracked(frozendict.fromkeys('ab', 1))) | ||
| self.assertFalse(gc.is_tracked(frozendict({1: 2}) | {3: 4})) |
Member
There was a problem hiding this comment.
please, test nested frozendicts :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.