gh-67217: Test both warnings implementations in environment variable tests - #155234
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-67217: Test both warnings implementations in environment variable tests#155234serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
…iable tests The code executed in the subprocess now disables the C implementation when the Python implementation is tested. Tests which only check sys.warnoptions do not depend on the implementation. They are moved to a separate test class and use the runInSubprocess() decorator. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CEnvironmentVariableTestsandPyEnvironmentVariableTestsexecuted the same code in a subprocess, so they both tested the C implementation. The code executed in the subprocess now disables the C implementation when the Python implementation is tested.Tests which only check
sys.warnoptionsdo not depend on the used implementation:sys.warnoptionsis set by the interpreter and is parsed by the same Python code in both cases. They are moved to a separate test class, are no longer duplicated, and use therunInSubprocess()decorator instead of running a source string in a subprocess.