[3.15] gh-154948: Fix test_zipfile failure when SOURCE_DATE_EPOCH is set (GH-155001) - #155347
Merged
Merged
Conversation
…EPOCH` is set (pythonGH-155001) (cherry picked from commit 82905dd) Co-authored-by: Stan Ulbrych <stan@python.org>
Documentation build overview
294 files changed ·
|
StanFromIreland
marked this pull request as ready for review
August 7, 2026 15:05
StanFromIreland
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
August 7, 2026 15:05
vstinner
approved these changes
Aug 7, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM. This fix can wait for Python 3.15.1.
Member
Author
These are just changes to tests, so I assume they won't be an issue? |
Member
As I wrote, I think that this change can wait for Python 3.15.1. No need to rush a fix in Python 3.15.0. |
Member
|
Tests can generally go in, they help improve the quality. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 82905dd)