gh-155426: correctly reject non-bytes keys in hmac.digest - #155427
Open
picnixz wants to merge 2 commits into
Open
gh-155426: correctly reject non-bytes keys in hmac.digest#155427picnixz wants to merge 2 commits into
hmac.digest#155427picnixz wants to merge 2 commits into
Conversation
This only affects keys of length smaller than the HMAC blocksize since larger keys are hashed first.
picnixz
force-pushed
the
meta/crypto/py/hmac/key-ljust-invalid-155426
branch
from
August 9, 2026 12:42
fe28b30 to
0c1bf69
Compare
picnixz
changed the title
hmac.digesthmac.digest
picnixz
added
needs backport to 3.13
picnixz
commented
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeErrorin pure Pythonhmac.digestfor non-bytes keys #155426