[3.13] gh-67765: Add tests for wsgiref.validate (GH-112398) - #155625
Merged
serhiy-storchaka merged 2 commits intoAug 12, 2026
Conversation
Cover the InputWrapper and ErrorWrapper methods of wsgiref.validate: read, readline, readlines, __iter__, write, writelines and flush. Each is tested both for the AssertionError raised on an invalid call and for the data passed through on a valid one. Co-authored-by: Alex Shkop <a.v.shkop@gmail.com> (cherry picked from commit e96cf73)
assertStartsWith() and assertEndsWith() are provided by test.support.testcase.ExtraAssertions in 3.13, so the new tests can be kept identical to the 3.14+ version. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover the InputWrapper and ErrorWrapper methods of wsgiref.validate: read, readline, readlines,
__iter__, write, writelines and flush.Each is tested both for the AssertionError raised on an invalid call and for the data passed through on a valid one.
assertEndsWith()andassertStartsWith()do not exist in 3.13, so the assertions useassertTrue(... .endswith(...))andassertTrue(... .startswith(...)), matching the style already used in this file.(cherry picked from commit e96cf73)
Co-authored-by: Amuthan Mannar amuthanmannar4@gmail.com
Co-authored-by: Alex Shkop a.v.shkop@gmail.com
🤖 Generated with Claude Code