Skip to content

[3.14] gh-102967: Don't pass None to seek(), simply truncate from the current position (GH-102968) #155665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 1 commit into from
Aug 13, 2026
+5 −1
Merged

[3.14] gh-102967: Don't pass None to seek(), simply truncate from the current position (GH-102968) #155665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Lib/doctest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,8 @@ def getvalue(self):
return result

def truncate(self, size=None):
self.seek(size)
if size is not None:
self.seek(size)
StringIO.truncate(self)

# Worst-case linear-time ellipsis matching.
Expand Down
1 change: 1 addition & 0 deletions Misc/ACKS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,7 @@ Lars Damerow
Evan Dandrea
Eric Daniel
Scott David Daniels
Aaron Davidson
Derzsi Dániel
Lawrence D'Anna
Ben Darnell
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Library/2023-03-23-19-47-05.gh-issue-102967.gfIYkN.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
A bug in :func:`!doctest._SpoofOut.truncate` was causing None to be passed to :func:`!StringIO.seek` when no size was given.
A simple fix skips the seek call when no size is given so the buffer can be truncated from the current position.
Loading