[3.15] gh-155752: Do not crash when GenericAlias parameters change during substitution (GH-155761) - #155770
Merged
Merged
Conversation
…ing substitution (pythonGH-155761) An alias argument can gain __typing_subst__ after __parameters__ has been cached, including during a preparation or substitution callback. Check that the argument is present before indexing the substitution arguments. (cherry picked from commit c0006faf4f48f01126a8a0752da8f159142e410d) Co-authored-by: Darius Houle <dariushoule@gmail.com>
miss-islington
requested review from
AlexWaygood and
JelleZijlstra
as code owners
August 14, 2026 05:14
|
All commit authors signed the Contributor License Agreement. |
This was referenced Aug 14, 2026
Closed
JelleZijlstra
approved these changes
Aug 14, 2026
Member
|
@dariushoule could you sign the CLA again? Seems like this commit got associated with a different email. See https://devguide.python.org/getting-started/pull-request-lifecycle/#why-do-i-need-to-sign-the-cla-again @picnixz could you approve this backport (since you already approved the original PR)? I'd like to get this in during the RC phase since it fixes a crash. |
picnixz
approved these changes
Aug 14, 2026
Contributor
|
@JelleZijlstra sure thing, done, my mistake! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alias argument can gain typing_subst after parameters has been cached, including during a preparation or substitution callback. Check that the argument is present before indexing the substitution arguments.
(cherry picked from commit c0006fa)
Co-authored-by: Darius Houle dariushoule@gmail.com