[3.13] gh-156894: Fix the position of syntax errors which cover a range (GH-156901) - #156928
Merged
serhiy-storchaka merged 2 commits intoSep 4, 2026
Merged
Conversation
pythonGH-156901) The callers of _PyTokenizer_syntaxerror_known_range() pass columns in bytes, but SyntaxError.offset and end_offset are columns in characters. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit 59a6913)
serhiy-storchaka
requested review from
iritkatriel,
lysnikolaou and
pablogsal
as code owners
September 4, 2026 11:21
serhiy-storchaka
enabled auto-merge (squash)
September 4, 2026 11:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callers of
_PyTokenizer_syntaxerror_known_range()pass columns in bytes, butSyntaxError.offsetandend_offsetare columns in characters.(cherry picked from commit 59a6913)
In 3.13 the error for incompatible string prefixes points at the string itself, not at the prefixes, so the expected positions of these test cases differ from the main branch.
Co-authored-by: Serhiy Storchaka storchaka@gmail.com