[3.13] gh-156091: Fix crash compiling deeply nested inlined comprehensions (GH-156957) - #157050
Open
iritkatriel wants to merge 1 commit into
Open
[3.13] gh-156091: Fix crash compiling deeply nested inlined comprehensions (GH-156957)#157050iritkatriel wants to merge 1 commit into
iritkatriel wants to merge 1 commit into
Conversation
…prehensions (pythonGH-156957) Count inlined-comprehension SETUP_FINALLY handlers toward CO_MAXBLOCKS. Manual backport of 14a93f4 / pythonGH-156993; 3.13 still has this code in compile.c. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Python/compile.cwith the oldfblocktypenames, so the fblock isINLINED_COMPREHENSIONrather thanCOMPILE_FBLOCK_INLINED_COMPREHENSION.CO_MAXBLOCKSand raiseSyntaxErrorinstead of overflowing the except stack.Test plan
./python.exe -m test test_syntax -m test_nested_inlined_comprehensions_block_limitMade with Cursor
_PyCfgExceptStack, bypassing theu_nfblocksblock-nesting limit #156091