Skip to content

Conversation

@delirious-lettuce
Copy link
Contributor

I noticed a single trailing semicolon in the datetime docs (link). It isn't used in a compound statement and seems to be inconsistent with the other surrounding examples.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@mention-bot
Copy link

@delirious-lettuce, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tiran, @birkenfeld and @abalkin to be potential reviewers.

@Mariatta Mariatta merged commit c7b3f0f into python:master May 19, 2017
@Mariatta
Copy link
Member

It's trivial so CLA is not needed.
Thanks @delirious-lettuce and congrats on your first contribution to CPython 🎉

@delirious-lettuce
Copy link
Contributor Author

@Mariatta ,

Thank you so much! It's slightly amusing to think my first contribution to Python was to take something away.

I've been going through the docs a bit more thoroughly and I've noticed a few typos (next contribution!). I hope that qualifies as trivial as well. I'm hesitant to sign the CLA because I kind of enjoy the pseudo-anonymity of GitHub. Is it true that your real name must be publicly posted after signing the CLA?

@delirious-lettuce delirious-lettuce deleted the trailing_semicolon branch May 19, 2017 01:42
@Mariatta
Copy link
Member

Core devs can make a judgment call whether a change is trivial or not. If it's typo fixes in the doc, then yes it's trivial, but it can depend on the size of the PR itself.

For me personally, when people signed the CLA, it can be nice for core devs. We have one less 'check' that we need to do, and we don't have to make that guess or judgment call of whether we can accept the PR or not.

Is it true that your real name must be publicly posted after signing the CLA?

Not sure about the "must be" part. We do list people's name in Misc/ACKS but I imagine people have the choice if they don't want to be added.

@delirious-lettuce
Copy link
Contributor Author

delirious-lettuce commented May 19, 2017

@Mariatta ,

I appreciate the response. I did notice the list of names while reading about contributing which is why I asked. I don't really mind signing the CLA, I just wouldn't want my name posted. Also, I'm not worried about getting credit for removing a semicolon (or fixing minor typos)!

I'm working on my next PR which has modified ~16 .rst files but each file might have 1-4 characters added/removed to fix typos. Hopefully that's small enough to again be considered trivial.

Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants