Skip to content

bpo-39603: Prevent header injection in http methods #18480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amiremohamadi wants to merge 2 commits into from
Closed

bpo-39603: Prevent header injection in http methods #18480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4a78ba
encode method parameter in putrequest to prevent http header injection
amiremohamadi Feb 12, 2020
80b123a
encode method parameter in putrequest to prevent http header injection
amiremohamadi Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Lib/http/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1086,7 +1086,8 @@ def putrequest(self, method, url, skip_host=False,
raise CannotSendRequest(self.__state)

# Save the method for use later in the response phase
self._method = method
# ASCII helps prevent http header injection
self._method = method.encode('ascii')

url = url or '/'
self._validate_path(url)
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Security/2020-02-12-14-17-39.bpo-39603.Gt3RSg.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Prevent http header injection by encoding method parameter in
http.client.putrequest(...) to ASCII.