Fix ast.rst demo code#18916
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
The change was done in #17172 cc: @pablogsal @isidentical |
|
I don't get why you closed and re-opened this PR? Is that a mistake or you want this version to be reviewed? |
Sorry I didn't read tirkarthi's comment clearly and mistakenly thought the correction was done in pr17172. |
|
Did you read the issue about why this 'copy_locations' removed in the first place? |
OK, I see. I'm closing this. But there's two issues after removing
class RewriteName(NodeTransformer):
def visit_Name(self, node):
return Subscript(
value=Name(id='data', ctx=Load()),
slice=Index(value=Constant(value=node.id)),
ctx=node.ctx
), node)
|
Missing
copy_locationin demo code.