Skip to content

bpo-45067 - Verify the version of ncurses for extended color support feature usage. #28260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orsenthil merged 5 commits into from
Sep 9, 2021
Merged

bpo-45067 - Verify the version of ncurses for extended color support feature usage. #28260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
296ceba
issue45067 - Fix _curses compilation in CentOS 7. Verify the version …
orsenthil Sep 9, 2021
fa0d550
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 9, 2021
17f1f39
Update Modules/_cursesmodule.c
Sep 9, 2021
d4285ab
Removed the non-matching comment.
orsenthil Sep 9, 2021
493fe45
Fix the news documentation.
orsenthil Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Misc/NEWS.d/next/Build/2021-09-09-16-45-26.bpo-45067.mFmY92.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
The ncurses function extended_color_content was introduced in 2017.
https://invisible-island.net/ncurses/NEWS.html#index-t20170401) The
ncurses-devel package in CentOS 7 had a older version ncurses resulted in
compilation error. For compiling ncurses with extended color support, we
verify the version of the ncurses library >= 20170401.
4 changes: 2 additions & 2 deletions Modules/_cursesmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,11 +135,11 @@ typedef chtype attr_t; /* No attr_t type is available */
#define STRICT_SYSV_CURSES
#endif

#if NCURSES_EXT_COLORS+0 && NCURSES_EXT_FUNCS+0
#if NCURSES_EXT_FUNCS+0 >= 20170401 && NCURSES_EXT_COLORS+0 >= 20170401
#define _NCURSES_EXTENDED_COLOR_FUNCS 1
#else
#define _NCURSES_EXTENDED_COLOR_FUNCS 0
#endif /* defined(NCURSES_EXT_COLORS) && defined(NCURSES_EXT_FUNCS) */
#endif

#if _NCURSES_EXTENDED_COLOR_FUNCS
#define _CURSES_COLOR_VAL_TYPE int
Expand Down