Skip to content

bpo-33207: Call super in Generic.__init_subclass__#6356

Merged
ilevkivskyi merged 1 commit intopython:masterfrom
ilevkivskyi:fix-generic-init-subclass
Apr 4, 2018
Merged

bpo-33207: Call super in Generic.__init_subclass__#6356
ilevkivskyi merged 1 commit intopython:masterfrom
ilevkivskyi:fix-generic-init-subclass

Conversation

@ilevkivskyi
Copy link
Copy Markdown
Member

@ilevkivskyi ilevkivskyi commented Apr 2, 2018

The fix is straightforward -- this just makes Generic cooperative by calling super()
in Generic.__init_subclass__.

https://bugs.python.org/issue33207

Copy link
Copy Markdown
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ilevkivskyi ilevkivskyi merged commit ee566fe into python:master Apr 4, 2018
@bedevere-bot
Copy link
Copy Markdown

@ilevkivskyi: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @ilevkivskyi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@ilevkivskyi ilevkivskyi deleted the fix-generic-init-subclass branch April 4, 2018 16:00
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 4, 2018
(cherry picked from commit ee566fe)

Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

GH-6372 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Apr 4, 2018
(cherry picked from commit ee566fe)

Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants