Skip to content

[3.7] bpo-33207: Call super in Generic.__init_subclass__ (GH-6356)#6372

Merged
miss-islington merged 1 commit intopython:3.7from
miss-islington:backport-ee566fe-3.7
Apr 4, 2018
Merged

[3.7] bpo-33207: Call super in Generic.__init_subclass__ (GH-6356)#6372
miss-islington merged 1 commit intopython:3.7from
miss-islington:backport-ee566fe-3.7

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Apr 4, 2018

(cherry picked from commit ee566fe)

Co-authored-by: Ivan Levkivskyi levkivskyi@gmail.com

https://bugs.python.org/issue33207

(cherry picked from commit ee566fe)

Co-authored-by: Ivan Levkivskyi <levkivskyi@gmail.com>
Copy link
Copy Markdown
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ilevkivskyi ilevkivskyi changed the title [3.7] Call super in Generic.__init_subclass__ (GH-6356) [3.7] bpo-33207: Call super in Generic.__init_subclass__ (GH-6356) Apr 4, 2018
Copy link
Copy Markdown
Member

@ilevkivskyi ilevkivskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this should be now auto-merged when tests pass.

@miss-islington
Copy link
Copy Markdown
Contributor Author

@ilevkivskyi: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit bd85c97 into python:3.7 Apr 4, 2018
@miss-islington
Copy link
Copy Markdown
Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-ee566fe-3.7 branch April 4, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants