Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33459: Fix "tuple displays" term in Expressions.rst #6760

Merged
merged 6 commits into from Sep 11, 2019

Conversation

@andresdelfino
Copy link
Contributor

commented May 10, 2018

@andresdelfino andresdelfino changed the title bpo-33459: Fix tuple displays bpo-33459: Fix "tuple displays" term in Expressions.rst May 10, 2018

@andresdelfino andresdelfino force-pushed the andresdelfino:fix-tuple-displays branch from c507ef4 to 4f6a58e Jul 15, 2018

Doc/reference/expressions.rst Outdated Show resolved Hide resolved
@vstinner

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

I removed the " needs backport to 3.6" label, the 3.6 branch no longer accept bugfixes (only security fixes are accepted): https://devguide.python.org/#status-of-python-branches

@JulienPalard

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

The proposed change is splitting the last line in two distinct lines. But the table gives one line per priority of precedence, so it would indicate they have different precedence, which looks wrong.

I would keep them in the same block.

@andresdelfino

This comment has been minimized.

Copy link
Contributor Author

commented Sep 10, 2019

The proposed change is splitting the last line in two distinct lines. But the table gives one line per priority of precedence, so it would indicate they have different precedence, which looks wrong.

I would keep them in the same block.

I agree, just updated the PR.

@matrixise
Copy link
Member

left a comment

Thank you for your contribution.

@miss-islington miss-islington merged commit dc26997 into python:master Sep 11, 2019

5 checks passed

Azure Pipelines PR #20190910.95 succeeded
Details
bedevere/issue-number Issue number 33459 found
Details
bedevere/news "skip news" label found
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miss-islington

This comment has been minimized.

Copy link

commented Sep 11, 2019

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒🤖

@miss-islington

This comment has been minimized.

Copy link

commented Sep 11, 2019

Thanks @andresdelfino for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒🤖

@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15939 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-33459: Fix "tuple displays" term in Expressions.rst (pythonGH-6760)
https://bugs.python.org/issue33459

Automerge-Triggered-By: @matrixise
(cherry picked from commit dc26997)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@bedevere-bot

This comment has been minimized.

Copy link

commented Sep 11, 2019

GH-15940 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
bpo-33459: Fix "tuple displays" term in Expressions.rst (pythonGH-6760)
https://bugs.python.org/issue33459

Automerge-Triggered-By: @matrixise
(cherry picked from commit dc26997)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
matrixise added a commit that referenced this pull request Sep 11, 2019
bpo-33459: Fix "tuple displays" term in Expressions.rst (GH-6760) (GH…
…-15939)

https://bugs.python.org/issue33459

Automerge-Triggered-By: @matrixise
(cherry picked from commit dc26997)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
matrixise added a commit that referenced this pull request Sep 11, 2019
bpo-33459: Fix "tuple displays" term in Expressions.rst (GH-6760) (GH…
…-15940)

https://bugs.python.org/issue33459

Automerge-Triggered-By: @matrixise
(cherry picked from commit dc26997)

Co-authored-by: Andre Delfino <adelfino@gmail.com>

@andresdelfino andresdelfino deleted the andresdelfino:fix-tuple-displays branch Sep 11, 2019

vrpolakatcisco added a commit to vrpolakatcisco/cpython that referenced this pull request Sep 12, 2019
DinoV added a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.