[3.7] bpo-33584: Fix several minor bugs in asyncio. (GH-7003) - #7005
Merged
Conversation
Fix the following bugs in the C implementation: * get_future_loop() silenced all exceptions raised when look up the get_loop attribute, not just an AttributeError. * enter_task() silenced all exceptions raised when look up the current task, not just a KeyError. * repr() was called for a borrowed link in enter_task() and task_step_impl(). * str() was used instead of repr() in formatting one error message (in Python implementation too). * There where few reference leaks in error cases. (cherry picked from commit 6655354) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Contributor
Author
|
@serhiy-storchaka: Backport status check is done, and it's a failure ❌ . |
1 similar comment
Contributor
Author
|
@serhiy-storchaka: Backport status check is done, and it's a failure ❌ . |
serhiy-storchaka
approved these changes
May 20, 2018
Contributor
Author
|
Thanks, @serhiy-storchaka! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the following bugs in the C implementation:
attribute, not just an AttributeError.
not just a KeyError.
Python implementation too).
(cherry picked from commit 6655354)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com
https://bugs.python.org/issue33584