Skip to content

bpo-33761: Fix a file leak in test_iterparse in test_xml_etree. - #7358

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:test_xml_etree-file-leak
Jun 3, 2018
Merged

bpo-33761: Fix a file leak in test_iterparse in test_xml_etree.#7358
serhiy-storchaka merged 1 commit into
python:masterfrom
serhiy-storchaka:test_xml_etree-file-leak

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 3, 2018

Copy link
Copy Markdown
Member

@scoder

scoder commented Jun 3, 2018

Copy link
Copy Markdown
Contributor

Looks good to me.

@serhiy-storchaka
serhiy-storchaka merged commit 13f51d9 into python:master Jun 3, 2018
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@serhiy-storchaka
serhiy-storchaka deleted the test_xml_etree-file-leak branch June 3, 2018 17:56
@bedevere-bot

Copy link
Copy Markdown

GH-7359 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2018
…onGH-7358)

(cherry picked from commit 13f51d9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-7360 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2018
…onGH-7358)

(cherry picked from commit 13f51d9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jun 3, 2018
)

(cherry picked from commit 13f51d9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-7363 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2018
…onGH-7358)

(cherry picked from commit 13f51d9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jun 4, 2018
)

(cherry picked from commit 13f51d9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants